|
From: | Avi Kivity |
Subject: | Re: [Qemu-devel] [PATCH] isa: Avoid using obsolete memory_region_set_offset for old portio |
Date: | Sun, 18 Sep 2011 18:57:00 +0300 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:6.0.2) Gecko/20110906 Thunderbird/6.0.2 |
On 09/18/2011 03:54 PM, Jan Kiszka wrote:
From: Jan Kiszka<address@hidden> We can express the offset of old portio completely via MemoryRegionPortio::offset by splitting up regions of different offsets and adjusting those offsets appropriately.
Please split into two patches - core and isa.
+ /* Copy the sub-list and null-terminate it. */ + pio = g_new(MemoryRegionPortio, count + 1); + memcpy(pio, pio_init, sizeof(MemoryRegionPortio) * count); + memset(pio + count, 0, sizeof(MemoryRegionPortio));
Wish: g_copy(pio, pio_init, count); // aka std::copy()
@@ -396,12 +395,12 @@ static void memory_region_iorange_read(IORange *iorange, *data = ((uint64_t)1<< (width * 8)) - 1; if (mrp) { - *data = mrp->read(mr->opaque, offset + mr->offset); + *data = mrp->read(mr->opaque, offset + mrp->offset); } else if (width == 2) { mrp = find_portio(mr, offset, 1, false); assert(mrp); - *data = mrp->read(mr->opaque, offset + mr->offset) | - (mrp->read(mr->opaque, offset + mr->offset + 1)<< 8); + *data = mrp->read(mr->opaque, offset + mrp->offset) | + (mrp->read(mr->opaque, offset + mrp->offset + 1)<< 8); } return; }
So long as mr->offset exists, you need to take it into account. And I don't want to remove memory_region_set_offset() until everything (that can potentially use it, at least) has been converted.
-- error compiling committee.c: too many arguments to function
[Prev in Thread] | Current Thread | [Next in Thread] |