[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] isa: Avoid using obsolete memory_region_set_off
From: |
Jan Kiszka |
Subject: |
Re: [Qemu-devel] [PATCH] isa: Avoid using obsolete memory_region_set_offset for old portio |
Date: |
Sun, 18 Sep 2011 21:16:16 +0200 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
On 2011-09-18 18:49, Richard Henderson wrote:
> On 09/18/2011 05:54 AM, Jan Kiszka wrote:
>> @@ -375,8 +375,7 @@ static const MemoryRegionPortio
>> *find_portio(MemoryRegion *mr, uint64_t offset,
>> const MemoryRegionPortio *mrp;
>>
>> for (mrp = mr->ops->old_portio; mrp->size; ++mrp) {
>> - if (offset >= mrp->offset && offset < mrp->offset + mrp->len
>> - && width == mrp->size
>> + if (offset < mrp->len && width == mrp->size
>
> This change looks broken to me. How, exactly, are you
> disambiguating different entries?
See my reply to Avi: all offsets of an portio region must be the same.
They should actually only differ in access width, but there is still at
least one counter example (of course IDE...). Given that this is just a
portability helper, all this will likely be reviewed and cleaned up when
getting rid of old portio.
Jan
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH] isa: Avoid using obsolete memory_region_set_offset for old portio, (continued)
- Re: [Qemu-devel] [PATCH] isa: Avoid using obsolete memory_region_set_offset for old portio, Avi Kivity, 2011/09/18
- Re: [Qemu-devel] [PATCH] isa: Avoid using obsolete memory_region_set_offset for old portio, Jan Kiszka, 2011/09/18
- Re: [Qemu-devel] [PATCH] isa: Avoid using obsolete memory_region_set_offset for old portio, Avi Kivity, 2011/09/18
- Re: [Qemu-devel] [PATCH] isa: Avoid using obsolete memory_region_set_offset for old portio, Jan Kiszka, 2011/09/18
- Re: [Qemu-devel] [PATCH] isa: Avoid using obsolete memory_region_set_offset for old portio, Avi Kivity, 2011/09/19
- Re: [Qemu-devel] [PATCH] isa: Avoid using obsolete memory_region_set_offset for old portio, Jan Kiszka, 2011/09/19
- Re: [Qemu-devel] [PATCH] isa: Avoid using obsolete memory_region_set_offset for old portio, Avi Kivity, 2011/09/19
- Re: [Qemu-devel] [PATCH] isa: Avoid using obsolete memory_region_set_offset for old portio, Jan Kiszka, 2011/09/19
- Re: [Qemu-devel] [PATCH] isa: Avoid using obsolete memory_region_set_offset for old portio, Avi Kivity, 2011/09/19
Re: [Qemu-devel] [PATCH] isa: Avoid using obsolete memory_region_set_offset for old portio, Richard Henderson, 2011/09/18
- Re: [Qemu-devel] [PATCH] isa: Avoid using obsolete memory_region_set_offset for old portio,
Jan Kiszka <=