Re: [Qemu-devel] [PATCH] isa: Avoid using obsolete memory_region_set_offset for old portio

[Jan Kiszka]

On 2011-09-18 18:49, Richard Henderson wrote:
> On 09/18/2011 05:54 AM, Jan Kiszka wrote:
>> @@ -375,8 +375,7 @@ static const MemoryRegionPortio 
>> *find_portio(MemoryRegion *mr, uint64_t offset,
>>      const MemoryRegionPortio *mrp;
>>  
>>      for (mrp = mr->ops->old_portio; mrp->size; ++mrp) {
>> -        if (offset >= mrp->offset && offset < mrp->offset + mrp->len
>> -            && width == mrp->size
>> +        if (offset < mrp->len && width == mrp->size
> 
> This change looks broken to me.  How, exactly, are you 
> disambiguating different entries?

See my reply to Avi: all offsets of an portio region must be the same.

They should actually only differ in access width, but there is still at
least one counter example (of course IDE...). Given that this is just a
portability helper, all this will likely be reviewed and cleaned up when
getting rid of old portio.

Jan

signature.asc
Description: OpenPGP digital signature