[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 5/7] target-mips:Support for Cavium specific ins
|
From: |
Andreas Färber |
|
Subject: |
Re: [Qemu-devel] [PATCH 5/7] target-mips:Support for Cavium specific instructions |
|
Date: |
Wed, 28 Sep 2011 10:29:18 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; de; rv:1.9.2.22) Gecko/20110907 SUSE/3.1.14 Thunderbird/3.1.14 |
Am 27.09.2011 06:17, schrieb address@hidden:
> From: Ehsan-ul-Haq, Abdul Qadeer, Abdul Waheed, Khansa Butt <address@hidden>
>
>
> Signed-off-by: Khansa Butt <address@hidden>
...nor all of mine from previous rounds. Including From vs.
Signed-off-by mixup (From is who sent the patch, not whom the code
originated from), Coding Style issues, misleading "Cavium specific"
comments, typos, ...
A space after the colon in the subject would be more visually pleasing, too.
Further, your patch series is completely missing versioning ([PATCH vX
n/m] and change log). Not seeing what you've actually changed for this
resubmission while still seeing unaddressed flaws we've pointed out
already becomes annoying after a while and will not help your patches
make it into the repository...
Regards,
Andreas
- [Qemu-devel] [PATCH 0/7] MIPS64 user mode emulation in QEMU with Cavium specific instruction support, khansa, 2011/09/27
- [Qemu-devel] [PATCH 1/7] linux-user:Support for MIPS64 user mode emulation in QEMU, khansa, 2011/09/27
- [Qemu-devel] [PATCH 2/7] target-mips:enabling of 64 bit user mode and floating point operations, khansa, 2011/09/27
- [Qemu-devel] [PATCH 3/7] linux-user:Signal handling for MIPS64, khansa, 2011/09/27
- [Qemu-devel] [PATCH 4/7] target-mips:Octeon cpu definition, khansa, 2011/09/27
- [Qemu-devel] [PATCH 5/7] target-mips:Support for Cavium specific instructions, khansa, 2011/09/27
- [Qemu-devel] [PATCH 6/7] Addition of Cavium instructions in disassembler, khansa, 2011/09/27