[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] tcg-i386: Introduce specific deposit helpers
|
From: |
Richard Henderson |
|
Subject: |
Re: [Qemu-devel] [PATCH] tcg-i386: Introduce specific deposit helpers |
|
Date: |
Wed, 28 Sep 2011 07:26:16 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:6.0.2) Gecko/20110906 Thunderbird/6.0.2 |
On 09/28/2011 05:28 AM, Jan Kiszka wrote:
> +#if TCG_TARGET_REG_BITS == 64
> + { INDEX_op_deposit8l_i32, { "r", "0", "r" } },
> +#else
> + { INDEX_op_deposit8l_i32, { "abcd", "0", "abcd" } },
> +#endif
At minimum, abcd is spelled "q".
I don't particularly care for the 3 different opcodes. Perhaps
we'd be better off with an inline predicate for when the deposit
opcode is "valid"?
r~
- [Qemu-devel] [PATCH] tcg-i386: Introduce specific deposit helpers, Jan Kiszka, 2011/09/28
- Re: [Qemu-devel] [PATCH] tcg-i386: Introduce specific deposit helpers,
Richard Henderson <=
- Re: [Qemu-devel] [PATCH] tcg-i386: Introduce specific deposit helpers, Jan Kiszka, 2011/09/28
- Re: [Qemu-devel] [PATCH] tcg-i386: Introduce specific deposit helpers, Richard Henderson, 2011/09/28
- Re: [Qemu-devel] [PATCH] tcg-i386: Introduce specific deposit helpers, Jan Kiszka, 2011/09/28
- Re: [Qemu-devel] [PATCH] tcg-i386: Introduce specific deposit helpers, Richard Henderson, 2011/09/28
- [Qemu-devel] [PATCH v2] tcg-i386: Introduce limited deposit support, Jan Kiszka, 2011/09/29
- Re: [Qemu-devel] [PATCH v2] tcg-i386: Introduce limited deposit support, Richard Henderson, 2011/09/29
- Re: [Qemu-devel] [PATCH v2] tcg-i386: Introduce limited deposit support, Jan Kiszka, 2011/09/29
- [Qemu-devel] [PATCH v3] tcg-i386: Introduce limited deposit support, Jan Kiszka, 2011/09/29
- Re: [Qemu-devel] [PATCH v3] tcg-i386: Introduce limited deposit support, Richard Henderson, 2011/09/29
- [Qemu-devel] [PATCH v4] tcg-i386: Introduce limited deposit support, Jan Kiszka, 2011/09/29