Re: [Qemu-devel] [PATCH 22/22] i8259: Move to hw library

[Blue Swirl]

On Wed, Sep 28, 2011 at 11:01 AM, Jan Kiszka <address@hidden> wrote:
> No target-specific bits remaining, let's move it over.
>
> Signed-off-by: Jan Kiszka <address@hidden>
> ---
>  Makefile.objs   |    2 +-
>  Makefile.target |    8 ++++----
>  2 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/Makefile.objs b/Makefile.objs
> index 1c65087..e56c18a 100644
> --- a/Makefile.objs
> +++ b/Makefile.objs
> @@ -276,7 +276,7 @@ hw-obj-$(CONFIG_AHCI) += ide/ich.o
>  hw-obj-$(CONFIG_LSI_SCSI_PCI) += lsi53c895a.o
>  hw-obj-$(CONFIG_ESP) += esp.o
>
> -hw-obj-y += dma-helpers.o sysbus.o isa-bus.o
> +hw-obj-y += dma-helpers.o sysbus.o isa-bus.o i8259.o

Please make this
hw-obj-$(CONFIG_I8259) += i8259.o
and adjust default-configs/*.

>  hw-obj-y += qdev-addr.o
>
>  # VGA
> diff --git a/Makefile.target b/Makefile.target
> index 88d2f1f..393f58d 100644
> --- a/Makefile.target
> +++ b/Makefile.target
> @@ -219,7 +219,7 @@ obj-$(CONFIG_IVSHMEM) += ivshmem.o
>
>  # Hardware support
>  obj-i386-y += vga.o
> -obj-i386-y += mc146818rtc.o i8259.o pc.o
> +obj-i386-y += mc146818rtc.o pc.o
>  obj-i386-y += cirrus_vga.o sga.o apic.o ioapic.o piix_pci.o
>  obj-i386-y += vmport.o
>  obj-i386-y += device-hotplug.o pci-hotplug.o smbios.o wdt_ib700.o
> @@ -232,7 +232,7 @@ obj-i386-$(CONFIG_SPICE) += qxl.o qxl-logger.o 
> qxl-render.o
>  obj-ppc-y = ppc.o
>  obj-ppc-y += vga.o
>  # PREP target
> -obj-ppc-y += i8259.o mc146818rtc.o
> +obj-ppc-y += mc146818rtc.o
>  obj-ppc-y += ppc_prep.o
>  # OldWorld PowerMac
>  obj-ppc-y += ppc_oldworld.o
> @@ -283,7 +283,7 @@ obj-lm32-y += framebuffer.o
>
>  obj-mips-y = mips_r4k.o mips_jazz.o mips_malta.o mips_mipssim.o
>  obj-mips-y += mips_addr.o mips_timer.o mips_int.o
> -obj-mips-y += vga.o i8259.o
> +obj-mips-y += vga.o
>  obj-mips-y += jazz_led.o
>  obj-mips-y += gt64xxx.o mc146818rtc.o
>  obj-mips-y += cirrus_vga.o
> @@ -365,7 +365,7 @@ obj-m68k-y += m68k-semi.o dummy_m68k.o
>
>  obj-s390x-y = s390-virtio-bus.o s390-virtio.o
>
> -obj-alpha-y = i8259.o mc146818rtc.o
> +obj-alpha-y = mc146818rtc.o
>  obj-alpha-y += vga.o cirrus_vga.o
>
>  obj-xtensa-y += xtensa_pic.o
> --
> 1.7.3.4
>
>
>