Re: [Qemu-devel] [PATCH 06/11] hw/ac97: new support for volume control

[Wayne Gao]

Hi Marc-André,


>>>
        ---
         hw/ac97.c |   79
        +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
         1 files changed, 79 insertions(+), 0 deletions(-)
        
        diff --git a/hw/ac97.c b/hw/ac97.c
        index ba94835..4a7c4ed 100644
        --- a/hw/ac97.c
        +++ b/hw/ac97.c
        @@ -431,6 +431,63 @@ static void reset_voices (AC97LinkState *s,
        uint8_t 
        ;
        
        ...
        
        -- 
        1.7.6.2
>>>

According to my test, my guest OS also can support for volume control
even I don't apply the patch to my code. I run my Ubuntu guest OS via
the following command:

qemu-system-x86_64 -M pc --enable-kvm -m 512 -smp 1 -name Ubuntu
-localtime -boot c -drive file=ubuntu.img,if=virtio,index=0  -vga cirrus
-chardev stdio,id=mon0 -mon chardev=mon0,mode=readline -chardev
socket,id=mon1,host=localhost,port=5554,server,nowait,telnet -mon
chardev=mon1,mode=control -soundhw ac97


By the way, my host OS is also Ubuntu 11.04 and I haven't apply your
patch [PATCH 04/11] and [PATCH 05/11] for hw/ac97.c to my code. Are
there any problems for my test?


Best Regards
Wayne Gao