Re: [Qemu-devel] [PATCH] pseries: Update SLOF firmware image

[David Gibson]

On Thu, Sep 29, 2011 at 12:31:39PM +0200, Paolo Bonzini wrote:
> On 09/29/2011 06:19 AM, David Gibson wrote:
> >This patch updates the SLOF submodule and recompiled image.  The new
> >SLOF versions contains two changes of note:
> >
> >  * The previous SLOF has a bug in SCSI condition handling that was
> >    exposed by recent updates to qemu's SCSI emulation.  This update
> >    fixes the bug.
> >
> >  * The previous SLOF has a bug in its addressing of SCSI devices,
> >    which can be exposed under certain conditions.  The new SLOF also
> >    fixes this.
> 
> Did you really fix this?  The SLOF.bin file here seems to be the
> same as in patch 50/58 from Alex's pull request, and the submodule
> likewise does not contain this fix.  Neither does your SLOF upstream
> repo, in fact. :)

Argh, dammit.  Pulled the new code, the forgot to push it to github.
Then pulled down github as submodule and built.  New spin coming.

> Also, you're not updating pc-bios/README.

Ah, yes.  Fixed.

-- 
David Gibson                    | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au  | minimalist, thank you.  NOT _the_ _other_
                                | _way_ _around_!
http://www.ozlabs.org/~dgibson