[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] [ARM] Fix sp804 dual-timer
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH] [ARM] Fix sp804 dual-timer |
Date: |
Fri, 30 Sep 2011 11:07:54 +0100 |
On 30 September 2011 10:23, Peter Chubb <address@hidden> wrote:
>>>>>> "Peter" == Peter Maydell <address@hidden> writes:
> Peter> hw_error() is a fatal error -- don't use it for conditions that
> Peter> can be triggered by a malicious guest. (And since it's noreturn
> Peter> there's not much point putting any code after it...)
>
> Is there a better `tell the programmer s/he's done something stupid'
> error function? The plxxx.c files all used hw_error() for bad
> offsets.
Unfortunately there isn't really a good infrastructure for this
kind of error. At the moment we have a mix of hw_error(), printing
to stderr, printing to stderr only if debug macros were enabled at
compile time, and silently ignoring things, all of which have
obvious drawbacks.
-- PMM