Re: [Qemu-devel] [PATCH] target-i386: Remove redundant word mask in port out instructions

[Blue Swirl]

Thanks, applied.

On Mon, Sep 26, 2011 at 5:20 PM, Jan Kiszka <address@hidden> wrote:
> T0 was already masked to 16 bits when loading it.
>
> Signed-off-by: Jan Kiszka <address@hidden>
> ---
>  target-i386/translate.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/target-i386/translate.c b/target-i386/translate.c
> index b894e97..1ef8d16 100644
> --- a/target-i386/translate.c
> +++ b/target-i386/translate.c
> @@ -6116,7 +6116,6 @@ static target_ulong disas_insn(DisasContext *s, 
> target_ulong pc_start)
>         if (use_icount)
>             gen_io_start();
>         tcg_gen_trunc_tl_i32(cpu_tmp2_i32, cpu_T[0]);
> -        tcg_gen_andi_i32(cpu_tmp2_i32, cpu_tmp2_i32, 0xffff);
>         tcg_gen_trunc_tl_i32(cpu_tmp3_i32, cpu_T[1]);
>         gen_helper_out_func(ot, cpu_tmp2_i32, cpu_tmp3_i32);
>         if (use_icount) {
> @@ -6159,7 +6158,6 @@ static target_ulong disas_insn(DisasContext *s, 
> target_ulong pc_start)
>         if (use_icount)
>             gen_io_start();
>         tcg_gen_trunc_tl_i32(cpu_tmp2_i32, cpu_T[0]);
> -        tcg_gen_andi_i32(cpu_tmp2_i32, cpu_tmp2_i32, 0xffff);
>         tcg_gen_trunc_tl_i32(cpu_tmp3_i32, cpu_T[1]);
>         gen_helper_out_func(ot, cpu_tmp2_i32, cpu_tmp3_i32);
>         if (use_icount) {
> --
> 1.7.3.4
>