Re: [Qemu-devel] [PATCH V11 0/5] Qemu Trusted Platform Module (TPM) integration

[Michael S. Tsirkin]

On Sun, Oct 02, 2011 at 04:12:14PM -0400, Stefan Berger wrote:
> On 10/02/2011 07:38 AM, Michael S. Tsirkin wrote:
> >On Wed, Sep 28, 2011 at 09:22:55AM -0400, Stefan Berger wrote:
> >>The following series of patches adds TPM (Trusted Platform Module) support
> >>to Qemu. An emulator for the TIS (TPM Interface Spec) interface is
> >>added that provides the basis for accessing a 'backend' implementing the 
> >>actual
> >>TPM functionality. The TIS emulator serves as a 'frontend' enabling for
> >>example Linux's TPM TIS (tpm_tis) driver.
> >>
> >>In this series I am posting a backend implementation that makes use of the
> >>host's TPM through a passthrough driver, which on Linux is accessed
> >>using /dev/tpm0.
> >Looks pretty clean, ACK to patches 1-4.
> Thanks.
> >The passthrough mode is quite easy to misuse, though most
> >of the problem is in the hardware, not on our side.
> >
> >I'm still trying to think of a good way to warn users
> >about the pitfalls with that. Disabling by default in configure, unless
> The documentation isn't enough?

Let's be frank with ourselves, no one reads documentation.

> If it's really needed could I add
> another patch on top of the existing V11?

Sure.

> >explictly required, is certainly one way.
> >And/or, let's rename it 'assigned' mode to resemble the name of
> >another fragile qemu feature :) Only half joking ...
> >
> Well, not sure what exactly you mean, but some things seem late
> versus closing time...
> 
>    Stefan