Re: [Qemu-devel] [PATCH 0/4] migration: Improve subsections detection

[Anthony Liguori]

On 10/04/2011 01:20 PM, Avi Kivity wrote:
> On 10/04/2011 04:38 PM, Juan Quintela wrote:
> > Hi
> >
> > This series move the subsections detection code form:
> > - Look that it starts form 5
> > To:
> > - Look that it starts form 5 (SUBSECTION)
> > - Look at the length
> > - Look that length is bigger than section name
> > - Look at the idstr and see that it starts with the subsection name.
> >
> > Please review.
>
> The original intent with subsections was to register them as a new vmstate
> section, with just a name relationship.
>
> Can we rename .subsections to .old_and_semi_broken_subsections, and introduce a
> new .subsections field that works properly in all cases?

That gets a bit hairy.  We don't really rely on section order today and I think 
this would introduce a section order requirement.  I don't think it's a problem 
and agree it's probably a better path but it does require a little bit of 
consideration.

Regards,

Anthony Liguori

>