qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 04/11] migration: return real error code


From: Anthony Liguori
Subject: Re: [Qemu-devel] [PATCH 04/11] migration: return real error code
Date: Wed, 05 Oct 2011 14:52:33 -0500
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.21) Gecko/20110831 Lightning/1.0b2 Thunderbird/3.1.13

On 10/04/2011 01:35 PM, Juan Quintela wrote:
Anthony Liguori<address@hidden>  wrote:
On 09/23/2011 07:50 AM, Juan Quintela wrote:
make functions propaget errno, instead of just using -EIO.

Signed-off-by: Juan Quintela<address@hidden>

qemu_file_has_error() implies a boolean response.  Wouldn't
qemu_file_get_error() make more sense if you're going to rely on the
return value?

I just didn't want to change more things on the same patch.
I can add a patch on top of this series?

It's terribly odd to make a function that looks like a bool return a non-boolean value. It can't be that much of a change to do it in this patch, it's just a matter of running sed.

Regards,

Anthony Liguori


Later, Juan.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]