[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2 11/23] i8259: Update IRQ state after reset
From: |
Jan Kiszka |
Subject: |
[Qemu-devel] [PATCH v2 11/23] i8259: Update IRQ state after reset |
Date: |
Fri, 7 Oct 2011 09:19:44 +0200 |
MIPS and PPC users of the i8259 output signal expect us to report state
updates also after reset. As no consumer (including the master PIC) can
misinterpret the deassert as an activation event, it is safe to simply
update the IRQ state after reset.
Signed-off-by: Jan Kiszka <address@hidden>
---
hw/i8259.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/hw/i8259.c b/hw/i8259.c
index b7a011f..3498c6b 100644
--- a/hw/i8259.c
+++ b/hw/i8259.c
@@ -283,6 +283,7 @@ static void pic_reset(void *opaque)
s->init4 = 0;
s->single_mode = 0;
/* Note: ELCR is not reset */
+ pic_update_irq(s->pics_state);
}
static void pic_ioport_write(void *opaque, target_phys_addr_t addr64,
@@ -298,8 +299,6 @@ static void pic_ioport_write(void *opaque,
target_phys_addr_t addr64,
if (val & 0x10) {
/* init */
pic_reset(s);
- /* deassert a pending interrupt */
- qemu_irq_lower(s->pics_state->pics[0].int_out);
s->init_state = 1;
s->init4 = val & 1;
s->single_mode = val & 2;
--
1.7.3.4
- [Qemu-devel] [PATCH v2 00/23] Rework i8259 and PC interrupt models, Jan Kiszka, 2011/10/07
- [Qemu-devel] [PATCH v2 01/23] pc: Drop useless test from isa_irq_handler, Jan Kiszka, 2011/10/07
- [Qemu-devel] [PATCH v2 03/23] pc: Convert GSIState::i8259_irq into array, Jan Kiszka, 2011/10/07
- [Qemu-devel] [PATCH v2 05/23] i8259: Remove premature inline function attributes, Jan Kiszka, 2011/10/07
- [Qemu-devel] [PATCH v2 06/23] i8259: Drop obsolete prototypes, Jan Kiszka, 2011/10/07
- [Qemu-devel] [PATCH v2 04/23] pc: Fix and clean up PIC-to-APIC IRQ path, Jan Kiszka, 2011/10/07
- [Qemu-devel] [PATCH v2 08/23] i8239: Introduce per-PIC output interrupt, Jan Kiszka, 2011/10/07
- [Qemu-devel] [PATCH v2 07/23] i8259: Move pic_set_irq1 after pic_update_irq, Jan Kiszka, 2011/10/07
- [Qemu-devel] [PATCH v2 11/23] i8259: Update IRQ state after reset,
Jan Kiszka <=
- [Qemu-devel] [PATCH v2 10/23] i8259: Reorder intack in pic_read_irq, Jan Kiszka, 2011/10/07
- [Qemu-devel] [PATCH v2 09/23] i8259: Do not update IRQ output after spurious pic_poll_read, Jan Kiszka, 2011/10/07
- [Qemu-devel] [PATCH v2 13/23] i8259: Switch to per-PIC IRQ update, Jan Kiszka, 2011/10/07
- [Qemu-devel] [PATCH v2 15/23] i8259: Clean up pic_ioport_read, Jan Kiszka, 2011/10/07
- [Qemu-devel] [PATCH v2 14/23] i8259: Fix poll command, Jan Kiszka, 2011/10/07
- [Qemu-devel] [PATCH v2 17/23] i8259: Replace PicState::pics_state with master flag, Jan Kiszka, 2011/10/07
- [Qemu-devel] [PATCH v2 12/23] i8259: Clear ELCR on reset, Jan Kiszka, 2011/10/07
- [Qemu-devel] [PATCH v2 02/23] pc: Generalize ISA IRQs to GSIs, Jan Kiszka, 2011/10/07
- [Qemu-devel] [PATCH v2 19/23] qdev: Add HEX8 property, Jan Kiszka, 2011/10/07