qemu-devel
[Top][All Lists]
Advanced
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 07/11] audio/spice: add support for volume contr

From: Gerd Hoffmann
Subject: Re: [Qemu-devel] [PATCH 07/11] audio/spice: add support for volume control
Date: Tue, 11 Oct 2011 10:49:28 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.22) Gecko/20110904 Red Hat/3.1.14-1.el6_1 Thunderbird/3.1.14 
  Hi,


+#else
+#warning "Spice playback volume unsupported"
+#endif



+#else
+#warning "Spice record volume unsupported"
+#endif
One warning is enougth. But given that qemu builds with -Werror by default printing a warning just because of an older spice-server version is a bad idea IMHO. 


@@ -337,6 +379,7 @@ struct audio_driver spice_audio_driver = {
      .max_voices_in  = 1,
      .voice_size_out = sizeof (SpiceVoiceOut),
      .voice_size_in  = sizeof (SpiceVoiceIn),
+    .ctl_caps       = VOICE_VOLUME_CAP


This should be #ifdef'ed too I guess?

cheers,
  Gerd
reply via email to
[Prev in Thread] Current Thread [Next in Thread]