[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] "console: Properly switch consoles for screen dumps" breaks
From: |
Alon Levy |
Subject: |
[Qemu-devel] "console: Properly switch consoles for screen dumps" breaks qxl screen dump |
Date: |
Tue, 11 Oct 2011 11:36:16 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Hi Jan,
I've recently found the $SUBJECT, it's commit
f81bdefb63243e82d16ce49332f7cf74d10b8f27.
I'd like to fix it without breaking anything, can you provide me with
the test that your original patch fixed?
Alon
p.s. for a simple command line with a single console (not even sure how
to get multiple) the following fixes my problem, I expect it doesn't
introduce any problems?
diff --git a/console.c b/console.c
index 6dfcc47..5a709fe 100644
--- a/console.c
+++ b/console.c
@@ -1067,6 +1067,10 @@ void console_select(unsigned int index)
if (index >= MAX_CONSOLES)
return;
+ if (active_console == consoles[index]) {
+ fprintf(stderr, "not changing console, not required\n");
+ return;
+ }
if (active_console) {
active_console->g_width = ds_get_width(active_console->ds);
active_console->g_height = ds_get_height(active_console->ds);
- [Qemu-devel] "console: Properly switch consoles for screen dumps" breaks qxl screen dump,
Alon Levy <=