[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 32/36] migration: Export a function that tells if th
From: |
Juan Quintela |
Subject: |
[Qemu-devel] [PATCH 32/36] migration: Export a function that tells if the migration has finished correctly |
Date: |
Tue, 11 Oct 2011 12:00:52 +0200 |
This will allow us to hide the state values.
Signed-off-by: Juan Quintela <address@hidden>
---
migration.c | 4 ++--
migration.h | 2 +-
ui/spice-core.c | 4 ++--
3 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/migration.c b/migration.c
index 6129cb5..c4e2ba6 100644
--- a/migration.c
+++ b/migration.c
@@ -364,9 +364,9 @@ void remove_migration_state_change_notifier(Notifier
*notify)
notifier_list_remove(&migration_state_notifiers, notify);
}
-int get_migration_state(void)
+bool migration_has_finished(MigrationState *s)
{
- return migrate_get_current()->state;
+ return s->state == MIG_STATE_COMPLETED;
}
void migrate_fd_connect(MigrationState *s)
diff --git a/migration.h b/migration.h
index f059183..7ae127f 100644
--- a/migration.h
+++ b/migration.h
@@ -84,7 +84,7 @@ void migrate_fd_connect(MigrationState *s);
void add_migration_state_change_notifier(Notifier *notify);
void remove_migration_state_change_notifier(Notifier *notify);
-int get_migration_state(void);
+bool migration_has_finished(MigrationState *);
uint64_t ram_bytes_remaining(void);
uint64_t ram_bytes_transferred(void);
diff --git a/ui/spice-core.c b/ui/spice-core.c
index 3cbc721..b33366e 100644
--- a/ui/spice-core.c
+++ b/ui/spice-core.c
@@ -447,9 +447,9 @@ void do_info_spice(Monitor *mon, QObject **ret_data)
static void migration_state_notifier(Notifier *notifier, void *data)
{
- int state = get_migration_state();
+ MigrationState *s = data;
- if (state == MIG_STATE_COMPLETED) {
+ if (migration_has_finished(s)) {
#if SPICE_SERVER_VERSION >= 0x000701 /* 0.7.1 */
spice_server_migrate_switch(spice_server);
#endif
--
1.7.6.4
- [Qemu-devel] [PATCH 18/36] migration: Rename FdMigrationState MigrationState, (continued)
- [Qemu-devel] [PATCH 18/36] migration: Rename FdMigrationState MigrationState, Juan Quintela, 2011/10/11
- [Qemu-devel] [PATCH 10/36] migration: set error if select return one error, Juan Quintela, 2011/10/11
- [Qemu-devel] [PATCH 26/36] migration: Remove get_status() accessor, Juan Quintela, 2011/10/11
- [Qemu-devel] [PATCH 27/36] migration: Remove migration cancel() callback, Juan Quintela, 2011/10/11
- [Qemu-devel] [PATCH 16/36] migration: Use FdMigrationState instead of MigrationState when possible, Juan Quintela, 2011/10/11
- [Qemu-devel] [PATCH 09/36] migration: don't "write" when migration is not active, Juan Quintela, 2011/10/11
- [Qemu-devel] [PATCH 33/36] migration: Make state definitions local, Juan Quintela, 2011/10/11
- [Qemu-devel] [PATCH 32/36] migration: Export a function that tells if the migration has finished correctly,
Juan Quintela <=
- [Qemu-devel] [PATCH 25/36] migration: Our release callback was just free, Juan Quintela, 2011/10/11
- Re: [Qemu-devel] [PATCH 25/36] migration: Our release callback was just free, Anthony Liguori, 2011/10/17