Re: [Qemu-devel] [PATCH 1/9] Add stub functions for PCI device models to do PCI DMA

[Gerd Hoffmann]

  Hi,

> > Yes.. as do the stX_pci_dma() helpers.  They assume LE, rather than
> > having two variants, because PCI is an LE spec, and all normal PCI
> > devices work in LE.
>
> IMO, not really. PCI devices do DMA any way they like.  LE is
> probably more common because both ARM and x86 processors are LE.

Also having _le_ in the function name makes explicitly clear that the 
functions read/write little endian values and byteswaps if needed, which 
makes the code more readable.  I'd suggest to add it even if there is no 
need for a _be_ companion as devices needing that are rare.

cheers,
  Gerd