[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 16/23] i8259: PREP: Replace pic_intack_read w
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH v2 16/23] i8259: PREP: Replace pic_intack_read with pic_read_irq |
Date: |
Wed, 12 Oct 2011 18:02:45 +0200 |
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; de; rv:1.9.2.23) Gecko/20110920 SUSE/3.1.15 Thunderbird/3.1.15 |
Hello Jan,
Since the last round of pulls, PReP magically boots again. :)
Am 07.10.2011 09:19, schrieb Jan Kiszka:
> There is nothing in the i8259 spec that justifies the special
> pic_intack_read. At least the Linux PREP kernels configure the PICs
> properly so that pic_read_irq returns identical values, and setting
> read_reg_select in PIC0 cannot be derived from any special i8259 mode.
>
> So switch ppc_prep to pic_read_irq and drop the now unused PIC code.
Seems to resolve an existing XXX in the code.
> CC: Andreas Färber <address@hidden>
> Signed-off-by: Jan Kiszka <address@hidden>
Linux is the only thing we can boot with -M prep that I'm aware of, via
-kernel. And the 40p series doesn't use this at all. I see no regression
on my Debian Etch, so I'm fine with the simplification.
Tested-by: Andreas Färber <address@hidden>
> diff --git a/hw/ppc_prep.c b/hw/ppc_prep.c
> index d26049b..6427baa 100644
> --- a/hw/ppc_prep.c
> +++ b/hw/ppc_prep.c
> @@ -130,7 +130,7 @@ static inline uint32_t
> _PPC_intack_read(target_phys_addr_t addr)
> uint32_t retval = 0;
>
> if ((addr & 0xf) == 0)
> - retval = pic_intack_read(isa_pic);
> + retval = pic_read_irq(isa_pic);
Mind to add the braces while touching it?
Regards,
Andreas
- [Qemu-devel] [PATCH v2 09/23] i8259: Do not update IRQ output after spurious pic_poll_read, (continued)
- [Qemu-devel] [PATCH v2 09/23] i8259: Do not update IRQ output after spurious pic_poll_read, Jan Kiszka, 2011/10/07
- [Qemu-devel] [PATCH v2 13/23] i8259: Switch to per-PIC IRQ update, Jan Kiszka, 2011/10/07
- [Qemu-devel] [PATCH v2 15/23] i8259: Clean up pic_ioport_read, Jan Kiszka, 2011/10/07
- [Qemu-devel] [PATCH v2 14/23] i8259: Fix poll command, Jan Kiszka, 2011/10/07
- [Qemu-devel] [PATCH v2 17/23] i8259: Replace PicState::pics_state with master flag, Jan Kiszka, 2011/10/07
- [Qemu-devel] [PATCH v2 12/23] i8259: Clear ELCR on reset, Jan Kiszka, 2011/10/07
- [Qemu-devel] [PATCH v2 02/23] pc: Generalize ISA IRQs to GSIs, Jan Kiszka, 2011/10/07
- [Qemu-devel] [PATCH v2 19/23] qdev: Add HEX8 property, Jan Kiszka, 2011/10/07
- [Qemu-devel] [PATCH v2 16/23] i8259: PREP: Replace pic_intack_read with pic_read_irq, Jan Kiszka, 2011/10/07
- Re: [Qemu-devel] [PATCH v2 16/23] i8259: PREP: Replace pic_intack_read with pic_read_irq,
Andreas Färber <=
- [Qemu-devel] [PATCH v2 21/23] i8259: Fix coding style, Jan Kiszka, 2011/10/07
- [Qemu-devel] [PATCH v2 22/23] monitor: Restrict pic/irq_info to supporting targets, Jan Kiszka, 2011/10/07
- [Qemu-devel] [PATCH v2 18/23] i8259: Eliminate PicState2, Jan Kiszka, 2011/10/07
- [Qemu-devel] [PATCH v2 20/23] i8259: Convert to qdev, Jan Kiszka, 2011/10/07
- [Qemu-devel] [PATCH v2 23/23] i8259: Move to hw library, Jan Kiszka, 2011/10/07
- Re: [Qemu-devel] [PATCH v2 00/23] Rework i8259 and PC interrupt models, Blue Swirl, 2011/10/15