Re: [Qemu-devel] [PATCH 1/2] Add opt_set_bool function

[Andreas Färber]

Am 12.10.2011 09:53, schrieb M. Mohan Kumar:
> In addition to qemu_opt_set function, we need a function to set bool value
> also.
>
> Signed-off-by: M. Mohan Kumar<address@hidden>
> ---
>   qemu-option.c |   35 +++++++++++++++++++++++++++++++++++
>   qemu-option.h |    1 +
>   2 files changed, 36 insertions(+), 0 deletions(-)
>
> diff --git a/qemu-option.c b/qemu-option.c
> index 105d760..d6bc908 100644
> --- a/qemu-option.c
> +++ b/qemu-option.c
> @@ -636,6 +636,41 @@ int qemu_opt_set(QemuOpts *opts, const char *name, const 
> char *value)
>       return 0;
>   }
>
> +int qemu_opt_set_bool(QemuOpts *opts, const char *name, int val)

Might it make sense to let qemu_opt_{get,set}_bool() use bool type?

Andreas

--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746, AG Nürnberg