|
| From: | Gerd Hoffmann |
| Subject: | Re: [Qemu-devel] [PATCH] ps2: migrate ledstate |
| Date: | Thu, 13 Oct 2011 09:49:21 +0200 |
| User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.23) Gecko/20110927 Red Hat/3.1.15-1.el6_1 Thunderbird/3.1.15 |
Hi,
One thing that could be improved after this patch is that the ledstate is now present both in spice-input and hw/ps2.c, but I couldn't find an easy way to get the ps2 ledstate from spice-input so I left things this way for now.
Directly linking ps/2 and spice-input would be wrong anyway as there are other keyboards (usb) too ...
input.c could cache the ledstate and offer a kbd_get_ledstate function, so anyone interested in the state doesn't need to keep it itself. That is a pretty minor thing though IMHO.
cheers, Gerd
| [Prev in Thread] | Current Thread | [Next in Thread] |