[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 22/35] scsi-disk: fix retrying a flush
From: |
Paolo Bonzini |
Subject: |
[Qemu-devel] [PATCH 22/35] scsi-disk: fix retrying a flush |
Date: |
Thu, 13 Oct 2011 13:03:52 +0200 |
Flush does not go anymore through scsi_disk_emulate_command.
Signed-off-by: Paolo Bonzini <address@hidden>
---
hw/scsi-disk.c | 9 +++------
1 files changed, 3 insertions(+), 6 deletions(-)
diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c
index 3f54891..860a3bf 100644
--- a/hw/scsi-disk.c
+++ b/hw/scsi-disk.c
@@ -81,7 +81,7 @@ struct SCSIDiskState
};
static int scsi_handle_rw_error(SCSIDiskReq *r, int error, int type);
-static int scsi_disk_emulate_command(SCSIDiskReq *r);
+static int32_t scsi_send_command(SCSIRequest *req, uint8_t *buf);
static void scsi_free_request(SCSIRequest *req)
{
@@ -336,7 +336,6 @@ static void scsi_dma_restart_bh(void *opaque)
r = DO_UPCAST(SCSIDiskReq, req, req);
if (r->status & SCSI_REQ_STATUS_RETRY) {
int status = r->status;
- int ret;
r->status &=
~(SCSI_REQ_STATUS_RETRY | SCSI_REQ_STATUS_RETRY_TYPE_MASK);
@@ -349,10 +348,8 @@ static void scsi_dma_restart_bh(void *opaque)
scsi_write_data(&r->req);
break;
case SCSI_REQ_STATUS_RETRY_FLUSH:
- ret = scsi_disk_emulate_command(r);
- if (ret == 0) {
- scsi_req_complete(&r->req, GOOD);
- }
+ scsi_send_command(&r->req, r->req.cmd.buf);
+ break;
}
/* This reference was left in by scsi_handle_rw_error. */
scsi_req_unref(&r->req);
--
1.7.6
- Re: [Qemu-devel] [PATCH 13/35] scsi: move tcq/ndev to SCSIBusOps (now SCSIBusInfo), (continued)
[Qemu-devel] [PATCH 16/35] scsi: implement REPORT LUNS for arbitrary LUNs, Paolo Bonzini, 2011/10/13
[Qemu-devel] [PATCH 18/35] scsi: add channel to addressing, Paolo Bonzini, 2011/10/13
[Qemu-devel] [PATCH 17/35] scsi: allow arbitrary LUNs, Paolo Bonzini, 2011/10/13
[Qemu-devel] [PATCH 22/35] scsi-disk: fix retrying a flush,
Paolo Bonzini <=
[Qemu-devel] [PATCH 01/35] scsi: pass correct sense code for ENOMEDIUM, Paolo Bonzini, 2011/10/13
[Qemu-devel] [PATCH 25/35] scsi-generic: check ioctl statuses when SG_IO succeeds, Paolo Bonzini, 2011/10/13
[Qemu-devel] [PATCH 24/35] scsi-generic: remove scsi_req_fixup, Paolo Bonzini, 2011/10/13
[Qemu-devel] [PATCH 23/35] scsi-generic: drop SCSIGenericState, Paolo Bonzini, 2011/10/13
[Qemu-devel] [PATCH 26/35] scsi-generic: look at host status, Paolo Bonzini, 2011/10/13
[Qemu-devel] [PATCH 33/35] scsi: export scsi_generic_reqops, Paolo Bonzini, 2011/10/13
[Qemu-devel] [PATCH 32/35] scsi: make reqops static const, Paolo Bonzini, 2011/10/13
[Qemu-devel] [PATCH 20/35] scsi-disk: do not complete requests twice, Paolo Bonzini, 2011/10/13
[Qemu-devel] [PATCH 19/35] scsi-disk: fail READ CAPACITY if LBA != 0 but PMI == 0, Paolo Bonzini, 2011/10/13