[Qemu-devel] [Bug 874038] Re: ARM thumb2 does not propogate carry flag properly

[Peter Maydell]

The existing code looks OK to me -- there's no need to call
gen_set_CF_bit31() early because the inputs t0 and t1 to
gen_thumb2_data_op() should always be distinct TCG values, and so
gen_thumb2_data_op() will never trash t1. (There was a bug in this area
involving ORN, but that was fixed in rev 29501f1, and I can see from
your patch that you have that fix.)

Can you clarify which exact instruction, input data and output data case
this patch is intended to fix, please?

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/874038

Title:
  ARM thumb2 does not propogate carry flag properly

Status in QEMU:
  New

Bug description:
  information on carry flag is lost if gen_set_CF_bit31(t1) is called
  after logic operation.

To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/874038/+subscriptions