Re: [Qemu-devel] [PATCH 1/1 V3] kernel/kvm: fix improper nmi emulation

[Avi Kivity]

On 10/14/2011 02:54 AM, Lai Jiangshan wrote:
> From: Kenji Kaneshige <address@hidden>
>
> Currently, NMI interrupt is blindly sent to all the vCPUs when NMI
> button event happens. This doesn't properly emulate real hardware on
> which NMI button event triggers LINT1. Because of this, NMI is sent to
> the processor even when LINT1 is maskied in LVT. For example, this
> causes the problem that kdump initiated by NMI sometimes doesn't work
> on KVM, because kdump assumes NMI is masked on CPUs other than CPU0.
>
> With this patch, KVM_NMI ioctl is handled as follows.
>
> - When in-kernel irqchip is enabled, KVM_NMI ioctl is handled as a
>   request of triggering LINT1 on the processor. LINT1 is emulated in
>   in-kernel irqchip.
>
> - When in-kernel irqchip is disabled, KVM_NMI ioctl is handled as a
>   request of injecting NMI to the processor. This assumes LINT1 is
>   already emulated in userland.
>
> (laijs) Add KVM_NMI API document
>
> Signed-off-by: Kenji Kaneshige <address@hidden>
> Tested-by: Lai Jiangshan <address@hidden>
>

Patch looks good, but please add your own sign-off (it needs to be added
even if you just forward the patch, and even more if you modify it).

-- 
error compiling committee.c: too many arguments to function