Re: [Qemu-devel] [PATCH v2 00/23] Rework i8259 and PC interrupt models

[Jan Kiszka]

On 2011-10-16 14:07, malc wrote:
> On Sun, 16 Oct 2011, Blue Swirl wrote:
> 
>> Thanks, applied all.
>>
>> On Fri, Oct 7, 2011 at 7:19 AM, Jan Kiszka <address@hidden> wrote:
>>> Highlights of this series:
>>>  - generic i8259, now part of hwlib
>>>  - qdev conversion of i8259
>>>  - fix for i8259 poll mode (and removal of PREP hack)
>>>
>>> The refactoring will also be important to instantiate i8259-kvm devices
>>> for in-kernel irqchip acceleration one day.
>>>
>>> Changes in v2:
>>>  - kept PIC irq state update after reset but clarified why this
>>>   required and only valid here
>>>  - additional fix: Clear ELCR on reset
> 
> It's not cleared on reset on real hardware..
> http://www.mail-archive.com/address@hidden/msg04569.html

It is, see Intel chipset specs.

It is not cleared - and that was likely the bug you once saw - when only
the PIC goes through reset, triggered via an ICWS. But that is handled
as a separate case now, no need to worry.

Jan

signature.asc
Description: OpenPGP digital signature