[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 0/3] coroutinization of flush and discard (sp
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH v2 0/3] coroutinization of flush and discard (split out of NBD series) |
Date: |
Mon, 17 Oct 2011 12:43:44 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:7.0) Gecko/20110927 Thunderbird/7.0 |
Am 17.10.2011 12:32, schrieb Paolo Bonzini:
> This series, applying on top of block branch, enables drivers to use
> coroutines for flush and discard. I kept aio_discard after discussing
> with Kevin since it should be useful not only for raw-posix-aio, but also
> for the userspace iSCSI backend (and in general for backends relying on
> an external library that is designed around aio).
>
> BTW, with this patch we get "for free" the invariant that bdrv_aio_*
> never returns a NULL acb (Stefan's patches already got to that point
> for read/write, of course).
Cool, I wasn't aware of that. That's a very nice side effect!
Maybe we should write this down in a comment and remove the now
unnecessary error handling from callers.
Kevin