qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 23/36] migration: Refactor and simplify error ch


From: Anthony Liguori
Subject: Re: [Qemu-devel] [PATCH 23/36] migration: Refactor and simplify error checking in migrate_fd_put_ready
Date: Mon, 17 Oct 2011 09:05:50 -0500
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.21) Gecko/20110831 Lightning/1.0b2 Thunderbird/3.1.13

On 10/11/2011 05:00 AM, Juan Quintela wrote:
Signed-off-by: Juan Quintela<address@hidden>

Just a general comment. This series is fairly touch to review because you're repeated refactoring the same function with no other comments beyond "refactor and simplify".

As a reviewer, I really have no help in understanding your motiviation for making this changes, why it can't be done all at once, etc.

I'm not rejecting this patch, but in the future, please put a little more care into better rationale in commit messages to simplify reviewing.

Reviewed-by: Anthony Liguori <address@hidden>

Regards,

Anthony Liguori


---
  migration.c |   21 ++++++++++-----------
  1 files changed, 10 insertions(+), 11 deletions(-)

diff --git a/migration.c b/migration.c
index a01bf4f..432afe6 100644
--- a/migration.c
+++ b/migration.c
@@ -372,23 +372,22 @@ static void migrate_fd_put_ready(void *opaque)
          DPRINTF("done iterating\n");
          vm_stop(RUN_STATE_FINISH_MIGRATE);

-        if ((qemu_savevm_state_complete(s->mon, s->file))<  0) {
-            if (old_vm_running) {
-                vm_start();
+        if (qemu_savevm_state_complete(s->mon, s->file)<  0) {
+            migrate_fd_error(s);
+        } else {
+            if (migrate_fd_cleanup(s)<  0) {
+                migrate_fd_error(s);
+            } else {
+                s->state = MIG_STATE_COMPLETED;
+                runstate_set(RUN_STATE_POSTMIGRATE);
+                notifier_list_notify(&migration_state_notifiers, NULL);
              }
-            s->state = MIG_STATE_ERROR;
          }
-        if (migrate_fd_cleanup(s)<  0) {
+        if (s->get_status(s) != MIG_STATE_COMPLETED) {
              if (old_vm_running) {
                  vm_start();
              }
-            s->state = MIG_STATE_ERROR;
          }
-        if (s->state == MIG_STATE_ACTIVE) {
-            s->state = MIG_STATE_COMPLETED;
-            runstate_set(RUN_STATE_POSTMIGRATE);
-        }
-        notifier_list_notify(&migration_state_notifiers, NULL);
      }
  }





reply via email to

[Prev in Thread] Current Thread [Next in Thread]