Re: [Qemu-devel] [PATCH 10/35] scsi-disk: support DVD profile in GET CONFIGURATION

[Paolo Bonzini]

On 10/17/2011 05:20 PM, Kevin Wolf wrote:
> > >  +    current = media_is_dvd(s) ? MMC_PROFILE_DVD_ROM : MMC_PROFILE_CD_ROM;
> > >  +    memset(outbuf, 0, 40);
> Is the memset required at all? I seem to remember that the output buffer
> was zeroed in generic code.

No, it isn't.

> > >  +    stl_be_p(&outbuf[0], 36); /* Bytes after the data length field */
> > >  +    /* outbuf[4] - outbuf[19]: Feature 0 - Profile list */
>
> Isn't it outbuf[8] - outbuf[19]?

Right.

Paolo