[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/4] qapi-types.py: Don't build paths by hand
From: |
Michael Roth |
Subject: |
Re: [Qemu-devel] [PATCH 2/4] qapi-types.py: Don't build paths by hand |
Date: |
Mon, 17 Oct 2011 16:20:46 -0500 |
Reviewed-by: Michael Roth <address@hidden>
On Mon, 17 Oct 2011 13:29:35 -0200, Luiz Capitulino <address@hidden> wrote:
> Use os.path.join() instead.
>
> Signed-off-by: Luiz Capitulino <address@hidden>
> ---
> scripts/qapi-types.py | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/scripts/qapi-types.py b/scripts/qapi-types.py
> index 986ff1e..8df4b72 100644
> --- a/scripts/qapi-types.py
> +++ b/scripts/qapi-types.py
> @@ -177,10 +177,10 @@ if __name__ == '__main__':
> if o in ("-p", "--prefix"):
> prefix = a
> elif o in ("-o", "--output-dir"):
> - output_dir = a + "/"
> + output_dir = a
>
> - c_file = output_dir + prefix + c_file
> - h_file = output_dir + prefix + h_file
> + c_file = os.path.join(output_dir, prefix + c_file)
> + h_file = os.path.join(output_dir, prefix + h_file)
>
> try:
> os.makedirs(output_dir)
> --
> 1.7.7.rc3
>
--
Sincerely,
Mike Roth
IBM Linux Technology Center