[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/7] integratorcp: convert control to memory API
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH 3/7] integratorcp: convert control to memory API |
Date: |
Tue, 18 Oct 2011 15:54:16 +0100 |
On 18 October 2011 15:32, Avi Kivity <address@hidden> wrote:
> On 10/18/2011 04:06 PM, Avi Kivity wrote:
>> > I didn't spot this the first time round, but this is wrong.
>> > We shouldn't be g_malloc0()ing the MemoryRegion -- it should
>> > be an element in some suitable device struct.
>> >
>> > I think the right thing to do here is probably first to do the
>> > (fairly trivial) conversion of the icp_control code to be a
>> > sysbus device, then do the memory region conversion on top of that.
>>
>> It's not any less wrong than the original code, which also leaked
>> memory. I'll merge it and let any further conversion take place on top.
>
> I meant, it's not any more wrong than the original code, though my
> original statement is also correct.
Either way, if you're happy to take it into your tree that's
fine with me :-)
-- PMM
[Qemu-devel] [PATCH 5/7] stellaris: convert i2c to memory API, Benoît Canet, 2011/10/17
[Qemu-devel] [PATCH 6/7] stellaris: convert adc to memory API, Benoît Canet, 2011/10/17
[Qemu-devel] [PATCH 7/7] stellaris: convert gptm to memory API, Benoît Canet, 2011/10/17
Re: [Qemu-devel] [PATCH 0/7] V2. Finish to convert integratorcp and stellaris to memory API, Avi Kivity, 2011/10/19