[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH] qed: don't pass NULL to memcpy
From: |
Pavel Borzenkov |
Subject: |
[Qemu-devel] [PATCH] qed: don't pass NULL to memcpy |
Date: |
Tue, 18 Oct 2011 21:17:35 +0400 |
Spotted by Clang Analyzer
Signed-off-by: Pavel Borzenkov <address@hidden>
---
block/qed.c | 6 ++++--
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/block/qed.c b/block/qed.c
index c3e45af..e6720db 100644
--- a/block/qed.c
+++ b/block/qed.c
@@ -1424,8 +1424,10 @@ static int bdrv_qed_change_backing_file(BlockDriverState
*bs,
memcpy(buffer, &le_header, sizeof(le_header));
buffer_len = sizeof(le_header);
- memcpy(buffer + buffer_len, backing_file, backing_file_len);
- buffer_len += backing_file_len;
+ if (backing_file) {
+ memcpy(buffer + buffer_len, backing_file, backing_file_len);
+ buffer_len += backing_file_len;
+ }
/* Write new header */
ret = bdrv_pwrite_sync(bs->file, 0, buffer, buffer_len);
--
1.7.0.4
- [Qemu-devel] [PATCH] qed: don't pass NULL to memcpy,
Pavel Borzenkov <=