Re: [Qemu-devel] [PATCH 09/21] target-sparc: Change fpr representation to doubles.

[Richard Henderson]

On 10/18/2011 01:28 PM, Blue Swirl wrote:
>> > +    static const char * const fregnames[32] = {
>> > +        "f0", "f2", "f4", "f6", "f8", "f10", "f12", "f14",
>> > +        "f16", "f18", "f20", "f22", "f24", "f26", "f28", "f30",
>> > +        "f32", "f34", "f36", "f38", "f40", "f42", "f44", "f46",
>> > +        "f48", "f50", "f52", "f54", "f56", "f58", "f60", "f62",
> Shouldn't these become "d0" etc?
> 

That's what I had at first, but then after looking at the dumps for
a few additional patches went back and changed it.  My feeling is
that these should match the disassembler, and it always uses f%d.

>> -        for (i = 0; i < TARGET_FPREGS; i++)
>> -            cpu_fpr[i] = tcg_global_mem_new_i32(TCG_AREG0,
>> +        for (i = 0; i < TARGET_DPREGS; i++)
> Please add braces.
> 

Sure.


r~