qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] libcacard: Fix wrong assertion (reported by cpp


From: Alon Levy
Subject: Re: [Qemu-devel] [PATCH] libcacard: Fix wrong assertion (reported by cppcheck)
Date: Thu, 20 Oct 2011 00:42:55 +0200
User-agent: Mutt/1.5.21 (2010-09-15)

On Wed, Oct 19, 2011 at 09:03:22PM +0200, Stefan Weil wrote:
> assert("...") will never do anything. This assertion handles a case
> which should never occur, so it must be assert(!"...").
> 

Thanks, I'll pick it up for a pull request.

> Cc: Alon Levy <address@hidden>
> Signed-off-by: Stefan Weil <address@hidden>
> ---
>  libcacard/card_7816.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/libcacard/card_7816.c b/libcacard/card_7816.c
> index 9fd59d4..6fe27d5 100644
> --- a/libcacard/card_7816.c
> +++ b/libcacard/card_7816.c
> @@ -754,7 +754,7 @@ vcard_process_apdu(VCard *card, VCardAPDU *apdu, 
> VCardResponse **response)
>          return vcard7816_vm_process_apdu(card, apdu, response);
>      case VCARD_DIRECT:
>          /* if we are type direct, then the applet should handle everything */
> -        assert("VCARD_DIRECT: applet failure");
> +        assert(!"VCARD_DIRECT: applet failure");
>          break;
>      }
>      *response =
> -- 
> 1.7.2.5
> 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]