[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/8] vmdk: fix return values of vmdk_parent_open
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH 2/8] vmdk: fix return values of vmdk_parent_open |
Date: |
Thu, 20 Oct 2011 11:16:16 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:7.0) Gecko/20110927 Thunderbird/7.0 |
Am 19.10.2011 16:59, schrieb Paolo Bonzini:
> While vmdk_open_desc_file (touched by the patch) correctly changed -1
> to -EINVAL, vmdk_open did not. Fix it directly in vmdk_parent_open.
>
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
> block/vmdk.c | 11 ++++++-----
> 1 files changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/block/vmdk.c b/block/vmdk.c
> index 5d16ec4..21566eb 100644
> --- a/block/vmdk.c
> +++ b/block/vmdk.c
> @@ -286,7 +286,7 @@ static int vmdk_parent_open(BlockDriverState *bs)
>
> desc[DESC_SIZE] = '\0';
> if (bdrv_pread(bs->file, s->desc_offset, desc, DESC_SIZE) != DESC_SIZE) {
> - return -1;
> + return -EINVAL;
> }
ret = bdrv_pread(...);
if (ret < 0) {
return ret;
}
Kevin
- Re: [Qemu-devel] [PATCH 1/8] vpc: detect floppy disk geometries, (continued)
- [Qemu-devel] [PATCH 4/8] block: add a Rwlock to synchronous read/write drivers, Paolo Bonzini, 2011/10/19
- [Qemu-devel] [PATCH 5/8] block: take lock around bdrv_read implementations, Paolo Bonzini, 2011/10/19
- [Qemu-devel] [PATCH 2/8] vmdk: fix return values of vmdk_parent_open, Paolo Bonzini, 2011/10/19
- Re: [Qemu-devel] [PATCH 2/8] vmdk: fix return values of vmdk_parent_open,
Kevin Wolf <=
- [Qemu-devel] [PATCH 6/8] block: take lock around bdrv_write implementations, Paolo Bonzini, 2011/10/19
- [Qemu-devel] [PATCH 7/8] block: change flush to co_flush, Paolo Bonzini, 2011/10/19
- [Qemu-devel] [PATCH 8/8] block: change discard to co_discard, Paolo Bonzini, 2011/10/19