Re: [Qemu-devel] [PATCH v2 4/6] tcg: Add interpreter for bytecode

[Stefan Weil]

Am 20.10.2011 23:36, schrieb malc:
> On Thu, 20 Oct 2011, Stefan Weil wrote:
>
> [..snip..]
>
> > +/* Trace message to see program flow. */
> > +#if defined(CONFIG_DEBUG_TCG_INTERPRETER)
> > +#define TRACE() \
> > +    loglevel \
> > +    ? fprintf(stderr, "TCG %s:%u: %s()\n", __FILE__, __LINE__, __func__) \
> > +    : (void)0
> This is wrong, fprintf's return value is int and not void. Similar issue
> was present today on comp.std.c
> http://groups.google.com/group/comp.std.c/browse_thread/thread/4e01fece59a80572#
>
> [..snip..]

You are right, but it does not matter. TRACE() is never used in
assignments, and gcc accepts the statement as it is.

Nevertheless, I' ll fix it in the next release.

Thanks,
Stefan