qemu-devel
[Top][All Lists]
Advanced
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 12/35] scsi-disk: report media changed via GET E

From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH 12/35] scsi-disk: report media changed via GET EVENT STATUS NOTIFICATION
Date: Fri, 21 Oct 2011 15:08:13 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:7.0) Gecko/20110927 Thunderbird/7.0 
On 10/21/2011 01:54 PM, Kevin Wolf wrote:

This adds support for media change notification via the GET EVENT STATUS
>  NOTIFICATION command, used by Linux versions 2.6.38 and newer.
>
>  Signed-off-by: Paolo Bonzini<address@hidden>

Looks good, but the ATAPI version of the code is somewhat nicer to read.
Yeah, on the other hand even the ATAPI version has a mix of structs and buffers (in event_status_media, which also assumes sizeof gesn_event_header == 4). 

Paolo
reply via email to
[Prev in Thread] Current Thread [Next in Thread]