Re: [Qemu-devel] [PATCH 0/4] add "make check"

[Kevin Wolf]

Am 24.10.2011 20:57, schrieb Anthony Liguori:
> On 10/24/2011 01:43 PM, Eduardo Habkost wrote:
>> On Mon, Sep 05, 2011 at 09:55:20AM +0200, Markus Armbruster wrote:
>>> Gerd Hoffmann<address@hidden>  writes:
>>>
>>>>    Hi,
>>>>
>>>> This patch series intends to make unit testing easier.  It adds a new
>>>> "make check" target which can be used to run all unit tests which are
>>>> currently in the tree.  It also enables the unit tests by default, so
>>>> you don't have to re-run configure with a special switch.
>>>
>>> Reviewed-by: Markus Armbruster<address@hidden>
>>>
>>> One test fails, but Luiz has a fix in his tree.
>>
>> Reviewed-by: Eduardo Habkost<address@hidden>
>>
>> Now all tests are passing. Why this was not applied yet?
> 
> I was hoping for more, but maybe we just need to start here and grow 
> organically, I'll queue it again.

A while ago I played with some simple IDE tests. It basically was a
small x86 kernel with an empty image that sends IDE commands and prints
some results, and a script that invokes the guest and checks whether the
test has passed or failed.

So at first I started with my own multiboot kernel and copied over some
parts of kvm-unittest's libc. Clearly not the best idea once it's more
than a couple of lines, so at some point I took the code and integrated
with my real kvm-unittests repository.

Now I don't have to duplicate code any more, but at the same time
there's no chance that a 'make check' in an upstream qemu tree could run
this. Tests for other devices will have exactly the same problem.

Any suggestions on how to go forward with this kind of tests? Should
this go into qemu or into kvm-unittests? Or should kvm-unittests be
merged into the qemu tree? Or is the approach completely wrong?

Kevin