[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 5/7] vmdk: Fix use of uninitialised value
From: |
Pavel Borzenkov |
Subject: |
Re: [Qemu-devel] [PATCH 5/7] vmdk: Fix use of uninitialised value |
Date: |
Wed, 26 Oct 2011 17:21:10 +0400 |
On Wed, Oct 26, 2011 at 4:31 PM, Kevin Wolf <address@hidden> wrote:
> In error cases, cid is never set.
>
> Signed-off-by: Kevin Wolf <address@hidden>
This fix is already in the qemu-trivial queue:
http://repo.or.cz/w/qemu/stefanha.git/commit/8379e46d1fd681b8aa4714382e2cdab05e5d0575
--
Pavel
> ---
> block/vmdk.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/block/vmdk.c b/block/vmdk.c
> index 6be592f..6cdbfb7 100644
> --- a/block/vmdk.c
> +++ b/block/vmdk.c
> @@ -208,7 +208,7 @@ static void vmdk_free_last_extent(BlockDriverState *bs)
> static uint32_t vmdk_read_cid(BlockDriverState *bs, int parent)
> {
> char desc[DESC_SIZE];
> - uint32_t cid;
> + uint32_t cid = 0;
> const char *p_name, *cid_str;
> size_t cid_str_size;
> BDRVVmdkState *s = bs->opaque;
> --
> 1.7.6.4
>
>
>
- [Qemu-devel] [PATCH 0/7] block: Collection of unrelated simple fixes, Kevin Wolf, 2011/10/26
- [Qemu-devel] [PATCH 1/7] block: Remove dead code, Kevin Wolf, 2011/10/26
- [Qemu-devel] [PATCH 2/7] block: Fix bdrv_open use after free, Kevin Wolf, 2011/10/26
- [Qemu-devel] [PATCH 4/7] ide: Fix off-by-one error in array index check, Kevin Wolf, 2011/10/26
- [Qemu-devel] [PATCH 5/7] vmdk: Fix use of uninitialised value, Kevin Wolf, 2011/10/26
- Re: [Qemu-devel] [PATCH 5/7] vmdk: Fix use of uninitialised value,
Pavel Borzenkov <=
- [Qemu-devel] [PATCH 6/7] vmdk: Improve error handling, Kevin Wolf, 2011/10/26
- [Qemu-devel] [PATCH 7/7] vmdk: Fix possible segfaults, Kevin Wolf, 2011/10/26
- [Qemu-devel] [PATCH 3/7] qcow: Fix bdrv_write_compressed error handling, Kevin Wolf, 2011/10/26