[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 05/10] qed: remove unneeded variable assignment
From: |
Stefan Hajnoczi |
Subject: |
[Qemu-devel] [PATCH 05/10] qed: remove unneeded variable assignment |
Date: |
Wed, 26 Oct 2011 15:22:08 +0100 |
From: Pavel Borzenkov <address@hidden>
'ret' is unconditionally overwitten by qed_read_l1_table_sync()
Spotted by Clang Analyzer
Signed-off-by: Pavel Borzenkov <address@hidden>
Signed-off-by: Stefan Hajnoczi <address@hidden>
---
block/qed.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/block/qed.c b/block/qed.c
index 7fab155..e6720db 100644
--- a/block/qed.c
+++ b/block/qed.c
@@ -388,7 +388,6 @@ static int bdrv_qed_open(BlockDriverState *bs, int flags)
if (ret < 0) {
return ret;
}
- ret = 0; /* ret should always be 0 or -errno */
qed_header_le_to_cpu(&le_header, &s->header);
if (s->header.magic != QED_MAGIC) {
--
1.7.7
- [Qemu-devel] [PULL 00/10] Trivial patches for October 15 to 26 2011, Stefan Hajnoczi, 2011/10/26
- [Qemu-devel] [PATCH 03/10] vmdk: vmdk_read_cid returns garbage if p_name is NULL, Stefan Hajnoczi, 2011/10/26
- [Qemu-devel] [PATCH 10/10] ahci: fix DPRINTF format strings, Stefan Hajnoczi, 2011/10/26
- [Qemu-devel] [PATCH 05/10] qed: remove unneeded variable assignment,
Stefan Hajnoczi <=
- [Qemu-devel] [PATCH 06/10] exec.c: Remove useless comment, Stefan Hajnoczi, 2011/10/26
- [Qemu-devel] [PATCH 02/10] vmdk: remove unneeded variable assignment, Stefan Hajnoczi, 2011/10/26
- [Qemu-devel] [PATCH 07/10] tools: reorganize Makefile variables, Stefan Hajnoczi, 2011/10/26
- [Qemu-devel] [PATCH 01/10] device_tree: Fix potential memory leak, Stefan Hajnoczi, 2011/10/26
- [Qemu-devel] [PATCH 04/10] qed: don't pass NULL to memcpy, Stefan Hajnoczi, 2011/10/26
- [Qemu-devel] [PATCH 09/10] Documentation: fix typ o, Stefan Hajnoczi, 2011/10/26
- [Qemu-devel] [PATCH 08/10] Fix typo: buf -> bus, Stefan Hajnoczi, 2011/10/26
- Re: [Qemu-devel] [PULL 00/10] Trivial patches for October 15 to 26 2011, Anthony Liguori, 2011/10/31