Re: [Qemu-devel] [PATCH v2 3/3] Make cpu_single_env thread-local

[Andreas Färber]

Am 27.10.2011 13:37, schrieb Peter Maydell:
> From: Paolo Bonzini <address@hidden>
> 
> Make cpu_single_env thread-local. This fixes a regression
> in handling of multi-threaded programs in linux-user mode
> (bug 823902).
> 
> Signed-off-by: Paolo Bonzini <address@hidden>
> [Peter Maydell: rename tls_cpu_single_env to cpu_single_env]
> Signed-off-by: Peter Maydell <address@hidden>
> ---
>  cpu-all.h |    4 +++-
>  exec.c    |    2 +-
>  2 files changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/cpu-all.h b/cpu-all.h
> index 42a5fa0..5f47ab8 100644
> --- a/cpu-all.h
> +++ b/cpu-all.h
> @@ -20,6 +20,7 @@
>  #define CPU_ALL_H
>  
>  #include "qemu-common.h"
> +#include "qemu-tls.h"
>  #include "cpu-common.h"
>  
>  /* some important defines:
[8<]

Is there a reason not to include this from qemu-common.h? To avoid
accidental use in unsuited cases? If so, add an explicit comment to
either qemu-common.h or Jan's comment in qemu-tls.h to avoid someone
doing such a cleanup/simplification patch?

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg