Re: [Qemu-devel] [PATCH] Support running QEMU on Valgrind

[Anthony Liguori]

On 10/31/2011 02:03 PM, Stefan Weil wrote:
> Am 31.10.2011 19:13, schrieb Anthony Liguori:
> > On 10/30/2011 07:07 AM, Stefan Weil wrote:
> > > Valgrind is a tool which can automatically detect many kinds of bugs.
> > >
> > > Running QEMU on Valgrind with x86_64 hosts was not possible because
> > > Valgrind aborts when memalign is called with an alignment larger than
> > > 1 MiB. QEMU normally uses 2 MiB on Linux x86_64.
> > >
> > > Now the alignment is reduced to the page size when QEMU is running on
> > > Valgrind.
> > >
> > > valgrind.h is a copy from Valgrind svn trunk r12226 with trailing
> > > whitespace stripped but otherwise unmodified, so it still raises lots
> > > of errors when checked with scripts/checkpatch.pl.
> > >
> > > It is included here to avoid a dependency on Valgrind.
> > >
> > > Signed-off-by: Stefan Weil<address@hidden>
> >
> > How about we just fix valgrind?
> >
> > Regards,
> >
> > Anthony Liguori
>
>
> Do you think that Valgrind will be fixed before tests of QEMU 1.0 start?
> I don't, and I think that using Valgrind should be part of these tests!
>
> I'd add the patch now. As soon as Valgrind is fixed, it can be reverted.
> Or we add another patch with the Valgrind hack from libvirt.

I definitely don't want to pull in a valgrind header.  The LD_PRELOAD check 
seems a bit ugly but I'd rather carry that as an intermediate solution.

Regards,

Anthony Liguori

> Regards,
> Stefan Weil