Re: [Qemu-devel] [PULL] tcg/interpreter: Add TCG + interpreter for bytecode

[Anthony Liguori]

On 10/31/2011 04:31 PM, Stefan Weil wrote:
> Hi,
>
> this is a 3rd version of the patch series which adds support for
> QEMU on any host by using a TCG interpreter (TCI).
>
> Version 2 was sent to the list and is available here:
> http://lists.gnu.org/archive/html/qemu-devel/2011-10/msg02504.html
>
> The new version removed the TRACE macros which I used during development.
> They are no longer needed. This fixes malc's feedback.
>
> Patches 1, 2, 5 and 6 are only rebased.
>
> Patch 1 is useful even without TCI and improves the handling of a
> special case needed for PPC hosts.
>
> Please tell me if I should send the complete patches to qemu-devel.
>
> I'd appreciate if the series could be pulled before QEMU 1.0 to form
> a base for further development of TCI.

I'll defer to Blue and/or Aurelien here as I don't know enough about TCG to 
really review this series.

But I'd recommend waiting to pull this until after 1.1 opens up.  This is the 
sort of thing that 1) people are likely to actually use and 2) could use a full 
development cycle of testing to get hardened before showing up in a release.

I'd feel better about pulling this into 1.0 if it was guarded by a configure 
option and disabled by default just to enforce that it's an experimental feature.

Regards,

Anthony Liguori

> Regards,
> Stefan Weil
>
>
> The following changes since commit ff74c5a9a91c6dbf1017195462aa4176f7381240:
>
> Merge remote-tracking branch 'riku/linux-user-for-upstream' into staging
> (2011-10-31 15:05:40 -0500)
>
> are available in the git repository at:
>
> git://qemu.weilnetz.de/qemu.git tci
>
> Stefan Weil (6):
> tcg: TCG targets may define tcg_qemu_tb_exec
> tcg: Make ARRAY_SIZE(tcg_op_defs) globally available
> tcg: Add bytecode generator for tcg interpreter
> tcg: Add interpreter for bytecode
> tcg: Add tci disassembler
> tcg: Add tcg interpreter to configure / make
>
> Makefile.target | 4 +
> configure | 34 ++-
> dis-asm.h | 1 +
> disas.c | 4 +-
> dyngen-exec.h | 12 +-
> exec-all.h | 22 +-
> tcg/ppc/tcg-target.h | 4 +
> tcg/tcg.c | 1 +
> tcg/tcg.h | 12 +-
> tcg/tci/README | 130 ++++++
> tcg/tci/tcg-target.c | 906 +++++++++++++++++++++++++++++++++++++
> tcg/tci/tcg-target.h | 160 +++++++
> tci-dis.c | 59 +++
> tci.c | 1208 ++++++++++++++++++++++++++++++++++++++++++++++++++
> 14 files changed, 2545 insertions(+), 12 deletions(-)
> create mode 100644 tcg/tci/README
> create mode 100644 tcg/tci/tcg-target.c
> create mode 100644 tcg/tci/tcg-target.h
> create mode 100644 tci-dis.c
> create mode 100644 tci.c