Re: [Qemu-devel] [PULL 00/22] ppc patch queue 2011-10-30

[Alexander Graf]

On 01.11.2011, at 14:41, Anthony Liguori <address@hidden> wrote:

> On 11/01/2011 04:05 PM, Blue Swirl wrote:
>> Thanks, pulled and reverted libfdt patch.
> 
> Er, this broke the build:
> 
>  CC    ppc64-softmmu/spapr_pci.o
> /home/anthony/git/qemu/hw/spapr_pci.c: In function ‘find_dev’:
> /home/anthony/git/qemu/hw/spapr_pci.c:54:9: error: ‘struct ChildrenHead’ has 
> no member named ‘lh_first’
> /home/anthony/git/qemu/hw/spapr_pci.c:54:9: error: ‘struct <anonymous>’ has 
> no member named ‘le_next’
> /home/anthony/git/qemu/hw/spapr_pci.c: In function 
> ‘spapr_populate_pci_devices’:
> /home/anthony/git/qemu/hw/spapr_pci.c:400:5: error: ‘struct ChildrenHead’ has 
> no member named ‘lh_first’
> /home/anthony/git/qemu/hw/spapr_pci.c:400:5: error: ‘struct <anonymous>’ has 
> no member named ‘le_next’
> make[1]: *** [spapr_pci.o] Error 1
> make: *** [subdir-ppc64-softmmu] Error 2
> 
> This is from commit:
> 
> commit 3384f95c59e5db381cf3e605c8acec71baf0e6b8
> Author: David Gibson <address@hidden>
> Date:   Sun Oct 30 17:16:46 2011 +0000
> 
>    pseries: Add partial support for PCI
> 
> And specifically:
> 
>        QLIST_FOREACH(qdev, &phb->host_state.bus->qbus.children, sibling) {
>            PCIDevice *dev = (PCIDevice *)qdev;
>            if (dev->devfn == devfn) {
>                return dev;
>            }
>        }
> 
> QBus::children is a QTAILQ, not a QLIST.
> 
> Was this code tested at all?

Uh, yeah. Compile and execution tested O_o.

Alex