|
From: | Supriya Kannery |
Subject: | Re: [Qemu-devel] [v8 Patch 5/6]Qemu: Framework for reopening images safely |
Date: | Fri, 04 Nov 2011 16:40:21 +0530 |
User-agent: | Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.20) Gecko/20110817 Fedora/3.1.12-1.fc14 Thunderbird/3.1.12 |
On 11/04/2011 03:35 PM, Kevin Wolf wrote:
Am 30.10.2011 11:35, schrieb Supriya Kannery:+struct BDRVReopenState { + BlockDriverState *bs; + int reopen_flags; + + /* For raw-posix */ + int reopen_fd; +};I think I commented the same on the previous version: BDRVReopenState shouldn't contain any format specific fields. raw-posix must extend the struct like this and use container_of() to get it from a BDRVReopenState pointer: struct BDRVRawReopenState { BDRVReopenState common; int reopen_fd; };
I don't recall this was suggested in prev version or may be I missed to notice..
ok, will have raw extending common BDRVReopenState struct.
Kevin
[Prev in Thread] | Current Thread | [Next in Thread] |