qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2] arm: Fix CP15 FSR (C5) domain setting


From: Jean-Christophe DUBOIS
Subject: Re: [Qemu-devel] [PATCH v2] arm: Fix CP15 FSR (C5) domain setting
Date: Sun, 06 Nov 2011 18:45:16 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:7.0.1) Gecko/20110929 Thunderbird/7.0.1

On 06/11/2011 18:33, Peter Maydell wrote:
On 5 November 2011 11:42, Jean-Christophe DUBOIS<address@hidden>  wrote:
During Xvisor development, it was noted that qemu did not return
the correct domain value in the Cp15 [Data] FSR register (C5).

This patch is a proposal to fix it.

v2:
- fix coding style
- rebase on git.

Signed-off-by: Jean-Christophe DUBOIS<address@hidden>

Reviewed-by: Peter Maydell<address@hidden>

NB: not going to put this into 1.0, it's a bit late and it's not
a critical bug fix IMHO. In particular, well behaved code shouldn't
be relying on this DFSR field; see the ARM ARM B3.9.7:
"From ARMv7, use of the domain field in the DFSR is deprecated. This
field might not be supported in future versions of the ARM architecture.
ARM strongly recommends that new software does not use this field."
Yes, same comment from the xvisor side of things. As xvisor targets mainly ARMv7 (and MIPS) for now, this was not a real issue.

Nonetheless this is worth fixing at some point in time (but this can be post 1.0).

JC


-- PMM





reply via email to

[Prev in Thread] Current Thread [Next in Thread]