Re: [Qemu-devel] [PATCH 1.0] ac97: don't override the pci subsystem id

[Anthony Liguori]

On 11/07/2011 08:42 AM, Avi Kivity wrote:
> On 11/07/2011 04:33 PM, Gerd Hoffmann wrote:
> > On 11/07/11 15:17, Avi Kivity wrote:
> > > On 11/07/2011 01:00 PM, Gerd Hoffmann wrote:
> > > > This patch removes the code lines which set the subsystem id for the
> > > > emulated ac97 card to 8086:0000.  Due to the device id being zero the
> > > > subsystem id isn't vaild anyway.  With the patch applied the sound card
> > > > gets the default qemu subsystem id (1af4:1100) instead.
> > >
> > > This a guest ABI change.  Do we want -M support for it?
> >
> > Given that the old subsystem id isn't valid I'd say no unless someone
> > comes up with a good reason.
>
> Do we know that Windows won't complain about it?

I thought the original motivation for the default subsystem ids was that some 
Windows test suite was explicitly complaining about having invalid subsystem ids?

Regards,

Anthony Liguori

>