qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 1.0] ac97: don't override the pci subsystem id


From: Anthony Liguori
Subject: Re: [Qemu-devel] [PATCH 1.0] ac97: don't override the pci subsystem id
Date: Mon, 07 Nov 2011 08:53:12 -0600
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.21) Gecko/20110831 Lightning/1.0b2 Thunderbird/3.1.13

On 11/07/2011 08:50 AM, Avi Kivity wrote:
On 11/07/2011 04:44 PM, Anthony Liguori wrote:
This a guest ABI change.  Do we want -M support for it?

Given that the old subsystem id isn't valid I'd say no unless someone
comes up with a good reason.

Do we know that Windows won't complain about it?


I thought the original motivation for the default subsystem ids was
that some Windows test suite was explicitly complaining about having
invalid subsystem ids?

I think so, but that's unrelated.  The worry is that some DRM code
checksums your hardware and complains if it changed too much.  Nothing
to do with the test suite.

The sense of Gerd's comment is reversed.  We should preserve the ABI
unless there is a strong reason not to.

Yes, I understand where you're coming from and I agree except when it comes to bug fixes.

My view toward bug fixes is the opposite--unless we know that the bug fix breaks something, we should fix the bug. If it's a bug, we have to assume it's breaking something.

Regards,

Anthony Liguori




reply via email to

[Prev in Thread] Current Thread [Next in Thread]