[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] arm-linux-user: fix elfload.c's AT_HWCAP reflec
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH] arm-linux-user: fix elfload.c's AT_HWCAP reflected cpu features. |
Date: |
Wed, 9 Nov 2011 14:06:52 +0000 |
2011/11/9 Andreas Färber <address@hidden>:
> I'm wondering if this translation table were better placed in
> target-arm/helper.c where we fiddle with the features in the first
> place. We could loop through all features here and call a function that
> returns the hwcap or 0 and |= it. Me and others will be adding new
> features and we'll risk adapting this here.
Hmm. It's really linux-specific so there's a good argument for
leaving it in linux-user. On the other hand I did just add some
extra features (arm div, vfpv4) without fixing the hwcaps so I
see your point...
Maybe we should just have a comment in cpu.h next to the
arm_features enum?
-- PMM