qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PATCH] hw/omap_gpmc.c: Add missing 'break's to fix 8 bit N


From: Peter Maydell
Subject: [Qemu-devel] [PATCH] hw/omap_gpmc.c: Add missing 'break's to fix 8 bit NAND writes
Date: Wed, 9 Nov 2011 17:42:23 +0000

Add missing 'break' statements which would have meant that writing
to an 8 bit NAND device was broken. Spotted by Coverity (see bug
887883).

Signed-off-by: Peter Maydell <address@hidden>
---
This is an embarrassing bug...

 hw/omap_gpmc.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/hw/omap_gpmc.c b/hw/omap_gpmc.c
index 7fc82a2..414f9f5 100644
--- a/hw/omap_gpmc.c
+++ b/hw/omap_gpmc.c
@@ -180,6 +180,7 @@ static void omap_nand_setio(DeviceState *dev, uint64_t 
value,
             nand_setio(dev, (value >> 24) & 0xff);
             break;
         }
+        break;
     case OMAP_GPMC_16BIT:
         switch (size) {
         case 1:
@@ -195,6 +196,7 @@ static void omap_nand_setio(DeviceState *dev, uint64_t 
value,
             nand_setio(dev, (value >> 16) & 0xffff);
             break;
         }
+        break;
     }
 }
 
-- 
1.7.1




reply via email to

[Prev in Thread] Current Thread [Next in Thread]