[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 6/8] x86/cpuid: Plug memory leak in cpudef_setfield(
From: |
Stefan Hajnoczi |
Subject: |
[Qemu-devel] [PATCH 6/8] x86/cpuid: Plug memory leak in cpudef_setfield() |
Date: |
Thu, 10 Nov 2011 12:36:42 +0000 |
From: Markus Armbruster <address@hidden>
To reproduce the leak, put two name options into the same [cpudef]
section of target-x86_64.conf.
Signed-off-by: Markus Armbruster <address@hidden>
Signed-off-by: Stefan Hajnoczi <address@hidden>
---
target-i386/cpuid.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/target-i386/cpuid.c b/target-i386/cpuid.c
index 352c390..99cff65 100644
--- a/target-i386/cpuid.c
+++ b/target-i386/cpuid.c
@@ -950,6 +950,7 @@ static int cpudef_setfield(const char *name, const char
*str, void *opaque)
int err = 0;
if (!strcmp(name, "name")) {
+ g_free((void *)def->name);
def->name = g_strdup(str);
} else if (!strcmp(name, "model_id")) {
strncpy(def->model_id, str, sizeof (def->model_id));
--
1.7.7.1
- [Qemu-devel] [PULL 0/8] Trivial patches for 8 to 10 November 2011, Stefan Hajnoczi, 2011/11/10
- [Qemu-devel] [PATCH 6/8] x86/cpuid: Plug memory leak in cpudef_setfield(),
Stefan Hajnoczi <=
- [Qemu-devel] [PATCH 7/8] x86/cpuid: Fix crash on -cpu "", Stefan Hajnoczi, 2011/11/10
- [Qemu-devel] [PATCH 1/8] qemu-tech.texi: Update default code cache size, Stefan Hajnoczi, 2011/11/10
- [Qemu-devel] [PATCH 3/8] qdev: Fix crash on -device '?=x', Stefan Hajnoczi, 2011/11/10
- [Qemu-devel] [PATCH 4/8] ui/vnc: Convert sasl.mechlist to g_malloc() & friends, Stefan Hajnoczi, 2011/11/10
- [Qemu-devel] [PATCH 8/8] hw/lan9118.c: Add missing 'break' to fix buffer overrun, Stefan Hajnoczi, 2011/11/10
- [Qemu-devel] [PATCH 2/8] configure: Show --cpu option on the help list, Stefan Hajnoczi, 2011/11/10
- [Qemu-devel] [PATCH 5/8] x86/cpuid: Convert remaining strdup() to g_strdup(), Stefan Hajnoczi, 2011/11/10
- Re: [Qemu-devel] [PULL 0/8] Trivial patches for 8 to 10 November 2011, Anthony Liguori, 2011/11/10