Re: [Qemu-devel] [RFC] vmstate: Add copyrights for all cpus

[Blue Swirl]

On Mon, Nov 7, 2011 at 17:38, Juan Quintela <address@hidden> wrote:
> Hi
>
> This patch adds copyrights to all the machine description files for
> all architectures supported. (this is done on top of my vmstate-cpus
> series patches) The problem?
>
> - What should we put as "copyirght" owners.
>
> Althought I modified almost every line of the files, mostly of the
> changes are a conversion, so claiming myself as the only "copyright"
> owner sounds at least pretentious, and more than probably false.
>
> I tried to "dig" into the git logs and tried to came with "whoever"
> commit the initial cpu_save/load foar each architecture.  I have put
> them as:
>
>  * Based on qemu-file support done by:
>  *   Richard Henderson <address@hidden>

I don't think this is correct at all.

> But I would preffer that the persons involved state what copyright
> notice they want, name, address, year(s), etc.  (Some architectures
> already have a propper copyright notice, I didn't touch them), and
> others had an empty file (I put mine there on the previosu series).
>
> Several of the logs are from the svn days, and then I don't know if
> the person was the committer, or the author.  If anyone contributed
> to the functionality and want to add its copyright, please told me.
>
> To make things more complicated, when machine.c files were split from
> vl.c, they didn't carry any copyright notice at all, should we copy
> back everything from vl.c?

Yes, vl.c says Copyright (c) 2003-2008 Fabrice Bellard and its license
is BSD like, not GPLv2only. I'd use those as a starting point for
machine files originating from vl.c.

> To make things more complicated, it looks like Thiemo Seufer did the
> original mips support, and he passed away.  So he can't obviously
> comment.
>
> Anthony asked me to send a patch to the list, asking form comments.
>
> alpha:
> CC: Richard Henderson <address@hidden>
>
> arm:
> CC: Andrzej Zaborowski <address@hidden>
>
>  (it appears as balrog, but on irc channel peter told me that balrog
>  has him)
>
> cris:
> CC: Edgar E. Iglesias <address@hidden>
>
> i386:
>
> Fabrice Bellard?
>
>  * Copyright (c) 2003-2008 Fabrice Bellard
>
> Didn't cc'd him because he left project/didn't have email address on
> MAINTAINERS/vl.c.  If you think that I should cc'd to him, just let me
> know.

Yes.

> lm32:
>
> CC: Michael Walle <address@hidden>
>
> mips:
>
> Thiemo Seufer?
>
> ppc & sparc:
>
> CC: Blue Swirl <address@hidden>

Sparc: I think I was behind e80cfcfc8884400e826328b772971913a14d0f44
aka SVN 1179 but Fabrice's hand was there too especially in later
commits.

PPC: OK except for license. Most definitely Nack for GPLv2only.

>
> What do you think, what should we do?  Juan.

In general the approach is fine.

> Signed-off-by: Juan Quintela <address@hidden>
>
> ---
>  target-alpha/vmstate-cpu.c |   15 +++++++++++++++
>  target-arm/vmstate-cpu.c   |   15 +++++++++++++++
>  target-cris/vmstate-cpu.c  |   15 +++++++++++++++
>  target-i386/vmstate-cpu.c  |   15 +++++++++++++++
>  target-lm32/vmstate-cpu.c  |   15 +++++++++++++++
>  target-mips/vmstate-cpu.c  |   15 +++++++++++++++
>  target-ppc/vmstate-cpu.c   |   15 +++++++++++++++
>  target-sparc/vmstate-cpu.c |   15 +++++++++++++++
>  8 files changed, 120 insertions(+), 0 deletions(-)
>
> diff --git a/target-alpha/vmstate-cpu.c b/target-alpha/vmstate-cpu.c
> index 156cb74..5525fab 100644
> --- a/target-alpha/vmstate-cpu.c
> +++ b/target-alpha/vmstate-cpu.c
> @@ -1,3 +1,18 @@
> +/*
> + * Migration support for alpha cpus
> + *
> + * Copyright (C) 2011 Red Hat, Inc.
> + *
> + * Author(s):
> + *  Juan Quintela <address@hidden>
> + *
> + * Based on qemu-file support done by:
> + *   Richard Henderson <address@hidden>
> + *
> + * This work is licensed under the terms of the GNU GPL, version 2.  See
> + * the COPYING file in the top-level directory.
> + */
> +
>  #include "hw/hw.h"
>
>  static int get_fpcr(QEMUFile *f, void *opaque, size_t size)
> diff --git a/target-arm/vmstate-cpu.c b/target-arm/vmstate-cpu.c
> index 836d9ed..4435540 100644
> --- a/target-arm/vmstate-cpu.c
> +++ b/target-arm/vmstate-cpu.c
> @@ -1,3 +1,18 @@
> +/*
> + * Migration support for arm cpus
> + *
> + * Copyright (C) 2011 Red Hat, Inc.
> + *
> + * Author(s):
> + *  Juan Quintela <address@hidden>
> + *
> + * Based on qemu-file support done by:
> + *  Andrzej Zaborowski <address@hidden>
> + *
> + * This work is licensed under the terms of the GNU GPL, version 2.  See
> + * the COPYING file in the top-level directory.
> + */
> +
>  #include "hw/hw.h"
>
>  static bool feature_vfp_needed(void *opaque)
> diff --git a/target-cris/vmstate-cpu.c b/target-cris/vmstate-cpu.c
> index 0f732d3..bbccb8b 100644
> --- a/target-cris/vmstate-cpu.c
> +++ b/target-cris/vmstate-cpu.c
> @@ -1,3 +1,18 @@
> +/*
> + * Migration support for cris cpus
> + *
> + * Copyright (C) 2011 Red Hat, Inc.
> + *
> + * Author(s):
> + *  Juan Quintela <address@hidden>
> + *
> + * Based on qemu-file support done by:
> + *  Edgar E. Iglesias <address@hidden>
> + *
> + * This work is licensed under the terms of the GNU GPL, version 2.  See
> + * the COPYING file in the top-level directory.
> + */
> +
>  #include "hw/hw.h"
>
>  static const VMStateDescription vmstate_tlbset = {
> diff --git a/target-i386/vmstate-cpu.c b/target-i386/vmstate-cpu.c
> index 838983e..8bb7ca8 100644
> --- a/target-i386/vmstate-cpu.c
> +++ b/target-i386/vmstate-cpu.c
> @@ -1,3 +1,18 @@
> +/*
> + * Migration support for x86 cpus
> + *
> + * Copyright (C) 2011 Red Hat, Inc.
> + *
> + * Author(s):
> + *  Juan Quintela <address@hidden>
> + *
> + * Based on qemu-file support done by:
> + *  Fabrice Bellard
> + *
> + * This work is licensed under the terms of the GNU GPL, version 2.  See
> + * the COPYING file in the top-level directory.
> + */
> +
>  #include "hw/hw.h"
>
>  static const VMStateDescription vmstate_segment = {
> diff --git a/target-lm32/vmstate-cpu.c b/target-lm32/vmstate-cpu.c
> index 60b4b29..99ce957 100644
> --- a/target-lm32/vmstate-cpu.c
> +++ b/target-lm32/vmstate-cpu.c
> @@ -1,3 +1,18 @@
> +/*
> + * Migration support for lm32 cpus
> + *
> + * Copyright (C) 2011 Red Hat, Inc.
> + *
> + * Author(s):
> + *  Juan Quintela <address@hidden>
> + *
> + * Based on qemu-file support done by:
> + *  Michael Walle <address@hidden>
> + *
> + * This work is licensed under the terms of the GNU GPL, version 2.  See
> + * the COPYING file in the top-level directory.
> + */
> +
>  #include "hw/hw.h"
>
>  const VMStateDescription vmstate_cpu = {
> diff --git a/target-mips/vmstate-cpu.c b/target-mips/vmstate-cpu.c
> index d6d7830..6b63af6 100644
> --- a/target-mips/vmstate-cpu.c
> +++ b/target-mips/vmstate-cpu.c
> @@ -1,3 +1,18 @@
> +/*
> + * Migration support for mips cpus
> + *
> + * Copyright (C) 2011 Red Hat, Inc.
> + *
> + * Author(s):
> + *  Juan Quintela <address@hidden>
> + *
> + * Based on qemu-file support done by:
> + *  Thiemo Seufer
> + *
> + * This work is licensed under the terms of the GNU GPL, version 2.  See
> + * the COPYING file in the top-level directory.
> + */
> +
>  #include "hw/hw.h"
>
>  static const VMStateDescription vmstate_tc = {
> diff --git a/target-ppc/vmstate-cpu.c b/target-ppc/vmstate-cpu.c
> index 1664d32..48dbc1a 100644
> --- a/target-ppc/vmstate-cpu.c
> +++ b/target-ppc/vmstate-cpu.c
> @@ -1,3 +1,18 @@
> +/*
> + * Migration support for ppc cpus
> + *
> + * Copyright (C) 2011 Red Hat, Inc.
> + *
> + * Author(s):
> + *  Juan Quintela <address@hidden>
> + *
> + * Based on qemu-file support done by:
> + *  Blue Swirl <address@hidden>
> + *
> + * This work is licensed under the terms of the GNU GPL, version 2.  See
> + * the COPYING file in the top-level directory.
> + */
> +
>  #include "hw/hw.h"
>
>  static const VMStateDescription vmstate_tlb = {
> diff --git a/target-sparc/vmstate-cpu.c b/target-sparc/vmstate-cpu.c
> index 259db19..35f9b0f 100644
> --- a/target-sparc/vmstate-cpu.c
> +++ b/target-sparc/vmstate-cpu.c
> @@ -1,3 +1,18 @@
> +/*
> + * Migration support for sparc cpus
> + *
> + * Copyright (C) 2011 Red Hat, Inc.
> + *
> + * Author(s):
> + *  Juan Quintela <address@hidden>
> + *
> + * Based on qemu-file support done by:
> + *  Blue Swirl <address@hidden>
> + *
> + * This work is licensed under the terms of the GNU GPL, version 2.  See
> + * the COPYING file in the top-level directory.
> + */
> +
>  #include "hw/hw.h"
>
>  static const VMStateDescription vmstate_cpu_timer = {
> --
> 1.7.7
>
>